Skip to content

Conversation

@SaturnFromTitan
Copy link
Contributor

Part of #29272

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jbrockmendel
Copy link
Member

lgtm

@WillAyd WillAyd added Clean Testing pandas testing functions or related to the test suite labels Oct 29, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 29, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well @jreback

@jbrockmendel
Copy link
Member

Merge conflicts are going to pile up if we dont merge this promptly, merging.

@jbrockmendel jbrockmendel merged commit 6c0e09f into pandas-dev:master Oct 29, 2019
@jbrockmendel
Copy link
Member

Thanks @SaturnFromTitan

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
…andas-dev#29273)

* Fixed test util imports in pandas/tests/series/test_timeseries.py

* Fixed test util imports in pandas/tests/series/test_analytics.py

* Fixed test util imports in pandas/tests/series/test_api.py

* Fixed test util imports in pandas/tests/series/test_apply.py

* Fixed test util imports in pandas/tests/series/test_combine_concat.py

* Fixed test util imports in pandas/tests/series/test_constructors.py

* Fixed test util imports in pandas/tests/series/test_datetime_values.py

* Fixed test util imports in pandas/tests/series/test_internals.py

* Fixed test util imports in pandas/tests/series/test_io.py

* Fixed test util imports in pandas/tests/series/test_missing.py

* Fixed test util imports in pandas/tests/series/test_operators.py

* Fixed test util imports in pandas/tests/series/test_rank.py

* Fixed test util imports in pandas/tests/series/test_sorting.py
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
…andas-dev#29273)

* Fixed test util imports in pandas/tests/series/test_timeseries.py

* Fixed test util imports in pandas/tests/series/test_analytics.py

* Fixed test util imports in pandas/tests/series/test_api.py

* Fixed test util imports in pandas/tests/series/test_apply.py

* Fixed test util imports in pandas/tests/series/test_combine_concat.py

* Fixed test util imports in pandas/tests/series/test_constructors.py

* Fixed test util imports in pandas/tests/series/test_datetime_values.py

* Fixed test util imports in pandas/tests/series/test_internals.py

* Fixed test util imports in pandas/tests/series/test_io.py

* Fixed test util imports in pandas/tests/series/test_missing.py

* Fixed test util imports in pandas/tests/series/test_operators.py

* Fixed test util imports in pandas/tests/series/test_rank.py

* Fixed test util imports in pandas/tests/series/test_sorting.py
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
…andas-dev#29273)

* Fixed test util imports in pandas/tests/series/test_timeseries.py

* Fixed test util imports in pandas/tests/series/test_analytics.py

* Fixed test util imports in pandas/tests/series/test_api.py

* Fixed test util imports in pandas/tests/series/test_apply.py

* Fixed test util imports in pandas/tests/series/test_combine_concat.py

* Fixed test util imports in pandas/tests/series/test_constructors.py

* Fixed test util imports in pandas/tests/series/test_datetime_values.py

* Fixed test util imports in pandas/tests/series/test_internals.py

* Fixed test util imports in pandas/tests/series/test_io.py

* Fixed test util imports in pandas/tests/series/test_missing.py

* Fixed test util imports in pandas/tests/series/test_operators.py

* Fixed test util imports in pandas/tests/series/test_rank.py

* Fixed test util imports in pandas/tests/series/test_sorting.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants