Skip to content

REF: remove unnecessary _try_cast calls #29642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 2 commits into from
Nov 16, 2019
Merged

REF: remove unnecessary _try_cast calls #29642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f9345
REF: remove unnecessary _try_cast calls
jbrockmendel Nov 15, 2019
aeedc9a
Merge branch 'master' of https://github.com/pandas-dev/pandas into fa…
jbrockmendel Nov 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/groupby/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ def _aggregate_named(self, func, *args, **kwargs):
output = func(group, *args, **kwargs)
if isinstance(output, (Series, Index, np.ndarray)):
raise ValueError("Must produce aggregated value")
result[name] = self._try_cast(output, group)
result[name] = output

return result

Expand Down
8 changes: 0 additions & 8 deletions pandas/core/groupby/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,14 +1357,6 @@ def f(self, **kwargs):

# apply a non-cython aggregation
result = self.aggregate(lambda x: npfunc(x, axis=self.axis))

# coerce the resulting columns if we can
if isinstance(result, DataFrame):
for col in result.columns:
result[col] = self._try_cast(result[col], self.obj[col])
else:
result = self._try_cast(result, self.obj)

return result

set_function_name(f, name, cls)
Expand Down