Skip to content

Conversation

@alimcmaster1
Copy link
Member

  • Towards CI: Use bash for Windows scripts on Azure #26344
  • This makes windows.yml and posix.yml steps pretty similar and they could potentially be merged/reduce duplication? (Will leave this for a separate PR)
  • We also now use ci/run_tests.sh for windows test stage.

Reference #27195 where I began this.

$(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"'
if ($matches[1] -eq 0)
{
$(Get-Content "test-data.xml" | Out-String) -match 'failures="(.*?)"'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes formatting of this powershell the same as posix.yml

@alimcmaster1 alimcmaster1 changed the title Mcmali conda warning CI: Use bash on windows Nov 17, 2019
@alimcmaster1 alimcmaster1 added the CI Continuous Integration label Nov 17, 2019
@alimcmaster1 alimcmaster1 changed the title CI: Use bash on windows CI: Use bash for windows script on azure Nov 17, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.0 milestone Nov 18, 2019
@WillAyd WillAyd merged commit e423bac into pandas-dev:master Nov 19, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 19, 2019

Thanks @alimcmaster1

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@alimcmaster1 alimcmaster1 deleted the mcmali-conda-warning branch December 25, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants