-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
BUG: Series groupby does not include nan counts for all categorical labels (#17605) #29690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI Output of `python scripts/validate_docstrings.py pandas.core.groupby.GroupBy._reindex_output`################################################################################ ########### Docstring (pandas.core.groupby.GroupBy._reindex_output) ########### ################################################################################If we have categorical groupers, then we might want to make sure that The method returns early without modifying the input if the number of Parametersoutput : Series or DataFrame ReturnsSeries or DataFrame ################################################################################ 1 Errors found: |
|
Thanks for the great feedback so far @TomAugspurger, @WillAyd, @jreback! I've made the requested changed, feel free to re-review. |
|
thanks @OliverHofkens nice patch! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis is a simple, low-impact fix for #17605.