f string in io.common

[daniellebrown]

• ref Replace old string formatting syntax with f-strings #29547
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[alimcmaster1]

Thanks for the PR! Please run black on your changes - see the code_check github actions

Checking black formatting
would reformat /home/runner/work/pandas/pandas/pandas/io/common.py
Oh no! 💥 💔 💥
1 file would be reformatted, 875 files would be left unchanged.

[alimcmaster1]

Please run black

[WillAyd]

Thanks for the PR. Looks good and I think CI failures are unrelated / have been fixed on master since this was created.

To be sure, can you locally on your shiny-new-feature branch run:

git fetch upstream
git merge upstream/master
git push origin shiny-new-feature

I think should get CI green for this. Flag me down at PyData if you have any questions

W.r.t black you will also want to run black pandas/io/common.py

[alimcmaster1]

If you merge master as @WillAyd suggested above test failures should be fixed

[WillAyd]

I think CI failure is unrelated yet again - can you merge master one more time to be sure?

[daniellebrown]

Hi,
I've attempted to merge to master, however, receive the following error messages. Any help much appreciated!

[jreback]

@daniellebrown you need to git push origin shiny-new-feature -f

[WillAyd]

@daniellebrown might want to try one more of:

git fetch upstream
git merge upstream/master
git push origin shiny-new-feature

To resolve CI failures

[simonjayhawkins]

@daniellebrown #30022 (comment) see https://dev.pandas.io/docs/development/contributing.html#python-pep8-black

[simonjayhawkins]

#30022 (comment)

[daniellebrown]

Any advice on how to fix this error:

would reformat /home/runner/work/pandas/pandas/pandas/io/common.py
Oh no! 💥 💔 💥
1 file would be reformatted, 880 files would be left unchanged.

I've run black several times and it doesn't seem to do the trick.

[simonjayhawkins]

@daniellebrown lgtm @WillAyd

[jreback]

thanks @daniellebrown very nice

[daniellebrown]

thanks @jreback @WillAyd @simonjayhawkins !