CLN: Removed unused code #30098
CLN: Removed unused code #30098
Conversation
|
|
||
| # extlinks alias | ||
| extlinks = { | ||
| "issue": ("https://github.com/pandas-dev/pandas/issues/%s", "GH"), |
There was a problem hiding this comment.
this is used! its how the links in the docs show up (wiki may not be used though)
There was a problem hiding this comment.
Oh, I tried to build the docs locally and I succeeded doing so, can you point me to where it used?
I just want to remove the use of % strings formmating.
There was a problem hiding this comment.
when u do :issue: it replaces with this string
There was a problem hiding this comment.
Oh wow, this is LITERALLY everywhere.
I really don't want to risk it.
@jreback do you think I should close this PR?
There was a problem hiding this comment.
yes, though in general removing unused code is encouraged. i like to use https://codecov.io/gh/pandas-dev/pandas/tree/master/pandas to find unused code (unfortunately it is out of date, hopefully thatll be fixed by #30070)
There was a problem hiding this comment.
Thank you so much for the tip @jbrockmendel
3 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff