Skip to content

TST: Regression testing for fixed issues #30646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 6 commits into from
Jan 3, 2020
Merged

TST: Regression testing for fixed issues #30646

mroeschke merged 6 commits into from
Jan 3, 2020

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 3, 2020

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jan 3, 2020
@mroeschke mroeschke added this to the 1.0 milestone Jan 3, 2020
simonjayhawkins
simonjayhawkins approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke minor nit otherwise lgtm

pandas/tests/reshape/test_pivot.py Outdated
expected = pd.DataFrame()
tm.assert_frame_equal(result, expected)

def test_pivot_table_no_column(self):
Copy link
Member

@simonjayhawkins simonjayhawkins Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_pivot_table_no_column(self):
def test_pivot_table_no_column_raises(self):

TomAugspurger
TomAugspurger approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green.

@mroeschke mroeschke merged commit 0ce0bb5 into pandas-dev:master Jan 3, 2020
@mroeschke mroeschke deleted the more_regression_testing branch January 3, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

ERR: better error reporting for passing list to level grouper on non-MultiIndex DataFrame.interpolate(axis=1, method="time", inplace=True) KeyError when using pivot_table with an aggfunc and and empty column aggregating with a dictionary that specifies a column that has all nan's fails to use numpy BUG: groupby with categorical drops empty groups when aggregating over a series
BUG: indexing with string in multi-index for Period gives KeyError Pandas attempts to convert some strings to timestamps when grouping by a timestamp and aggregating? pivot_table passes junk to aggfunc when value column does not exist Interpreting passed slicers in using .loc(axis=1) |#AssertionError: Start slice bound is non-scalar BUG: frame creation with multi-index and tuples in dict

3 participants

@mroeschke @TomAugspurger @simonjayhawkins