Skip to content

TST: Added 'match=' to some bare pytest.raises #30825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WillAyd merged 1 commit into from
Jan 8, 2020
Merged

TST: Added 'match=' to some bare pytest.raises #30825

WillAyd merged 1 commit into from
Jan 8, 2020

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Jan 8, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@ShaharNaveh ShaharNaveh changed the title TST: Removed some bare pytest raises TST: Added 'match=' to some bare pytest.raises Jan 8, 2020
WillAyd
WillAyd approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jan 8, 2020
@WillAyd WillAyd added this to the 1.0 milestone Jan 8, 2020
@WillAyd WillAyd merged commit 6df9dae into pandas-dev:master Jan 8, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 8, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the TST-bare-pytest-raise-batch-1 branch January 8, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @WillAyd