Skip to content

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 13, 2020

@MarcoGorelli MarcoGorelli changed the title 🐛 -1 to the power of pd.NA was returning -1 [BUG] -1 to the power of pd.NA was returning -1 Jan 13, 2020
@simonjayhawkins simonjayhawkins added this to the 1.0.0 milestone Jan 13, 2020
@simonjayhawkins simonjayhawkins added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations labels Jan 13, 2020
@MarcoGorelli
Copy link
Member Author

##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

I don't know what to make of this error, sorry

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonjayhawkins
Copy link
Member

@jorisvandenbossche in these situations is a whatsnew note needed?

@jorisvandenbossche
Copy link
Member

That's not needed in this case, since it is a new feature, not a bugfix compared to a previous release.

@simonjayhawkins
Copy link
Member

although it's a user reported bug from the rc release. could be worth considering in future having a short section in the whatsnew listing changes since the rc.

@TomAugspurger
Copy link
Contributor

I think we're OK without one.

@TomAugspurger TomAugspurger merged commit 7ba53f0 into pandas-dev:master Jan 13, 2020
@TomAugspurger
Copy link
Contributor

Thanks @MarcoGorelli!

sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jan 13, 2020
BUG: -1 to the power of pd.NA was returning -1 (pandas-dev#30960)
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport 1.0.x

@jorisvandenbossche
Copy link
Member

For some reason this got not backported (we will need to check it a bit ...)

jorisvandenbossche pushed a commit that referenced this pull request Jan 13, 2020
…30983)

Co-authored-by: Marco Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
@MarcoGorelli MarcoGorelli deleted the minus-one-to-pd-na branch February 25, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: rpow with -1 and pd.NA should return pd.NA

4 participants