Skip to content

CLN: update _simple_new usages #31089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 3 commits into from
Jan 18, 2020
Merged

CLN: update _simple_new usages #31089

jreback merged 3 commits into from
Jan 18, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 16, 2020

In preparation for making the _simple_new constructors stricter, xref #31084, #31055.

WillAyd
WillAyd approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added Clean ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 17, 2020
@jbrockmendel jbrockmendel added the Constructors Series/DataFrame/Index/pd.array Constructors label Jan 17, 2020
@jreback jreback added this to the 1.1 milestone Jan 18, 2020
@jreback jreback merged commit 8b754fc into pandas-dev:master Jan 18, 2020
@jreback
Copy link
Contributor

jreback commented Jan 18, 2020

pre-cursor to #31055 ?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 18, 2020

pre-cursor to #31055 ?

No, #31055 should be independent of this. But there are a few more PRs similar to 31055 coming up, and this is a precursor to some of those (and/or makes the diffs more focused)

@jbrockmendel jbrockmendel deleted the simple-prep branch January 18, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Clean Constructors Series/DataFrame/Index/pd.array Constructors ExtensionArray Extending pandas with custom dtypes or arrays.

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jreback @WillAyd