BUG: Fix qcut for nullable integers #31440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
reviewed
Jan 31, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| - | ||
| - | ||
|
|
||
| - Bug where :meth:`qcut` would raise when passed a nullable integer. (:issue:`31389`) |
Member
There was a problem hiding this comment.
I think this can go in the 1.0.1 whatsnew now that it's been created.
added 6 commits
January 31, 2020 08:34
Don't want this to raise with "unlucky" test data that doesn't have high enough cardinality
Contributor
|
pls merge master as well |
added 7 commits
February 1, 2020 09:24
jreback
requested changes
Feb 2, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. can you move the comments, ping on green.
pandas/core/reshape/tile.py
Outdated
| """ | ||
| # NOTE: this binning code is changed a bit from histogram for var(x) == 0 | ||
|
|
||
| # for handling the cut for datetime and timedelta objects |
Contributor
There was a problem hiding this comment.
ok, can you move all of these comments inside _coerce_to_type
jreback
approved these changes
Feb 2, 2020
Contributor
|
great long on green |
Contributor
Author
|
@jreback All green, thanks for the review |
Contributor
|
thanks @dsaxton |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 2, 2020
jreback
pushed a commit
that referenced
this pull request
Feb 2, 2020
Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasRelated to #31389 but doesn't close any issues that I'm aware of. Seems the problems were indexing into a numpy array with a BooleanArray and using searchsorted in the presence of pd.NA.