BUG: using loc[int] with object index #31905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Bug
Indexing
jreback
requested changes
Feb 22, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
can you add a whatsnew note (maybe api breaking changes to raise visibility)
jreback
approved these changes
Feb 22, 2020
Contributor
|
lgtm. merge on green. |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
* BUG: using loc[int] with object index * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis causes us to raise KeyError instead of TypeError in a couple of places, consistent with #31867.
Also note this leaves us with only one non-plotting usage of
holds_integer, and it wouldnt surprise me if that one is subtly causing problems too.