WEB: Add greeting note to CoC #32024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should be good - can you merge master to get green? |
MarcoGorelli
force-pushed
the
hey-everyone
branch
from
aa3a7a0 to
f5d3922
Compare
web/pandas/about/team.md
Outdated
| > or anyone willing to increase the diversity of our team. | ||
| > We have identified visible gaps and obstacles in sustaining diversity and inclusion in the open-source communities and we are proactive in increasing | ||
| > the diversity of our team. | ||
| > We welcome inclusive behavior - for example, please don’t say “hey guys!” but “hey everyone!”. |
Member
There was a problem hiding this comment.
This is the team page, doesn't seem relevant to me here. Should it be in the code of conduct instead?
Member
|
I agree this feels a bit "out of place" where it is added now |
datapythonista
approved these changes
Feb 26, 2020
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
lgtm, thanks @MarcoGorelli
Member
|
If you can merge master, looks like something (I guess unrelated) failed. |
MarcoGorelli
force-pushed
the
hey-everyone
branch
from
873ae61 to
c0aea1e
Compare
Member
|
Thanks @MarcoGorelli |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed something similar in the CPython contributing docs:
and thought it was really nice.
Pushing directly rather than opening as good first issue to avoid invoking a s*******m