REGR: read_pickle fallback to encoding=latin_1 upon a UnicodeDecodeError #32055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @pedroreys generally looks good. couple of suggestions.
simonjayhawkins
added
IO Pickle
WillAyd
requested changes
Feb 20, 2020
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
Looks good; question on the whastnew change
simonjayhawkins
approved these changes
Feb 20, 2020
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
@pedroreys thanks for the changes. lgtm ex @WillAyd comment
simonjayhawkins
changed the title
When a reading a pickle with MultiIndex columns generated in py27 `pickle_compat.load()` with `enconding=None` would throw an UnicodeDecodeError when reading a pickle created in py27. Now, `read_pickle` catches that exception and fallback to use `latin-1` explicitly.
Cleanup the code so that it only has a single catch for UnicodeDecodeError
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
pedroreys
force-pushed
the
31988_ReadPickle
branch
from
5757a4b to
08c007d
Compare
Member
|
LGTM |
jorisvandenbossche
approved these changes
Feb 21, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 21, 2020
…latin_1 upon a UnicodeDecodeError
Member
|
Thanks @pedroreys ! |
simonjayhawkins
pushed a commit
that referenced
this pull request
Feb 21, 2020
…on a UnicodeDecodeError (#32154) Co-authored-by: Pedro Reys <pedroreys@gmail.com>
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
…ror (pandas-dev#32055) When a reading a pickle with MultiIndex columns generated in py27 `pickle_compat.load()` with `enconding=None` would throw an UnicodeDecodeError when reading a pickle created in py27. Now, `read_pickle` catches that exception and fallback to use `latin-1` explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a reading a pickle with MultiIndex columns generated in py27
pickle_compat.load()withenconding=Nonewould throw an UnicodeDecodeErrorwhen reading a pickle created in py27. Now,
read_picklecatches that exception andfallback to use
latin-1explicitly.read_picklewhen loading a DataFrame with MultiIndex columns from a pickle created in py27 #31988black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff