Skip to content

REG: dont call func on empty input #32121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 4 commits into from
Feb 21, 2020
Merged

REG: dont call func on empty input #32121

jreback merged 4 commits into from
Feb 21, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 19, 2020 •
edited
Loading

Could use confirmation from OP that this does in fact close #31760.

@jbrockmendel jbrockmendel added the Regression Functionality that used to work in a prior pandas version label Feb 19, 2020
@jbrockmendel jbrockmendel added this to the 1.0.2 milestone Feb 19, 2020
WillAyd
WillAyd requested changes Feb 20, 2020
View reviewed changes
WillAyd
WillAyd approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit c0066f3 into pandas-dev:master Feb 21, 2020
@jreback
Copy link
Contributor

jreback commented Feb 21, 2020

thanks @jbrockmendel

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 21, 2020
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#32121: REG: dont call func on empty input
342821a
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 21, 2020
Merged
@jbrockmendel jbrockmendel deleted the 31760 branch February 21, 2020 18:40
simonjayhawkins pushed a commit that referenced this pull request Feb 21, 2020
@meeseeksmachine @jbrockmendel
Backport PR #32121: REG: dont call func on empty input (#32159)
9c95e16 
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@jbrockmendel @roberthdevries
REG: dont call func on empty input (pandas-dev#32121)
5f3e253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Groupby Regression Functionality that used to work in a prior pandas version

Projects

None yet

Milestone

1.0.2

Development

Successfully merging this pull request may close these issues.

groupby().agg() calls the user function for an extra time with empty inputs in 1.0.0

4 participants

@jbrockmendel @jreback @WillAyd @simonjayhawkins