Skip to content

CLN: _libs.interval looping with cdef index #32329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbrockmendel merged 2 commits into from
Feb 28, 2020
Merged

CLN: _libs.interval looping with cdef index #32329

jbrockmendel merged 2 commits into from
Feb 28, 2020

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Feb 28, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@ShaharNaveh ShaharNaveh changed the title CLN: _libs.interval lopping with cdef index CLN: _libs.interval looping with cdef index Feb 28, 2020
WillAyd
WillAyd approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Clean label Feb 28, 2020
@WillAyd WillAyd added this to the 1.1 milestone Feb 28, 2020
@jbrockmendel
Copy link
Member

jbrockmendel commented Feb 28, 2020

sure

@jbrockmendel jbrockmendel merged commit b512ed5 into pandas-dev:master Feb 28, 2020
@jbrockmendel
Copy link
Member

jbrockmendel commented Feb 28, 2020

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CLN-_libs-interval branch February 29, 2020 10:25
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@ShaharNaveh @roberthdevries
CLN: _libs.interval looping with cdef index (pandas-dev#32329)
b32b8a8 
* CLN: using "n" variable to loop

* cdef for "i" as index and for "n" as the length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @jbrockmendel @WillAyd