Skip to content

CLN: Avoid unnecessary values_from_object #32398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Mar 3, 2020
Merged

CLN: Avoid unnecessary values_from_object #32398

jreback merged 1 commit into from
Mar 3, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Mar 2, 2020

xref #27165.

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Mar 2, 2020

What are the cases where asarray and values_from_object would give a different result?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Mar 2, 2020

What are the cases where asarray and values_from_object would give a different result?

They should only ever be distinct for EA dtypes, none of which is the case here

@jreback jreback added the Clean label Mar 3, 2020
@jreback jreback added this to the 1.1 milestone Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

great. yeah this was for compatibility when we removed Series from subclassing ndarray (like 0.13 or so), so would be nice to actually completely remove values_from_object

@jreback jreback merged commit 08deb10 into pandas-dev:master Mar 3, 2020
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Mar 3, 2020

so would be nice to actually completely remove values_from_object

Yah, I got tripped up the other day by PeriodIndex.values and am now tilting at windmills to get rid of a few patterns like this.

@jbrockmendel jbrockmendel deleted the no-values3 branch March 3, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jorisvandenbossche @jreback