BUG: Don't multiply sets during construction #32594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 10, 2020
Member
|
Hmm how is this type of construction actually useful? If anything this should probably just raise |
Contributor
Author
Yeah, I could see that too. Looks like it does raise in the |
Member
|
If Series raises then I think that is even more motivation to raise here; this seems more likely to be a programmer error than intent |
jreback
requested changes
Mar 11, 2020
pandas/core/construction.py
Outdated
| # GH#16804 | ||
| arr = np.arange(data.start, data.stop, data.step, dtype="int64") | ||
| subarr = _try_cast(arr, dtype, copy, raise_cast_failure) | ||
| elif isinstance(data, set): |
jreback
approved these changes
Mar 15, 2020
Contributor
|
thanks @dsaxton |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff