BUG: DataFrame.at with non-unique axes #33047
Conversation
jreback
added
the
Indexing
| @property | ||
| def _axes_are_unique(self) -> bool: | ||
| # Only relevant for self.ndim == 2 | ||
| return self.obj.index.is_unique and self.obj.columns.is_unique |
There was a problem hiding this comment.
can you add this assertion explicity
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
(need to discuss the desired behaviour)
|
i think consensus on the call was to move forward with this? |
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
yes we discussed moving forward here. @jorisvandenbossche recollection correct?
|
gentle ping |
Yes, as also summarized on the issue (#33153) |
| def __getitem__(self, key): | ||
| if self.ndim == 2 and not self._axes_are_unique: | ||
| # GH#33041 fall back to .loc | ||
| return self.obj.loc[key] |
There was a problem hiding this comment.
One problem with this, though, is that it allows any kind of indexer for this case (not only scalar ones), and thus relaxing the requirements for .at
There was a problem hiding this comment.
Updated to address this issue
|
gentle ping |
|
Thanks! (BTW, if you have 2 approvals and no others commenting/requesting changes, I think it is fine to merge yourself) |
Good rule of thumb, thanks |
3 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffCloses #33041 in conjunction with #33045.