Skip to content

ENH: Add index option to_markdown() #33091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 30 commits into from
Jul 15, 2020
Merged

ENH: Add index option to_markdown() #33091

jreback merged 30 commits into from
Jul 15, 2020

Conversation

@quangngd
Copy link
Contributor

@quangngd quangngd commented Mar 28, 2020

@jreback jreback added Enhancement IO Data IO issues that don't fit into a more specific label labels Mar 29, 2020
@jreback jreback added this to the 1.1 milestone Mar 29, 2020
jreback
jreback requested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you add a release note in other enhancements for 1.1 ping on green.

@quangngd
Copy link
Contributor Author

quangngd commented Mar 30, 2020

@jreback apparently, the pytest.warns in my test is an unwanted pattern. Should i remove that part of code and ignore the testcase when index and showindex is both set?

jreback
jreback requested changes Mar 30, 2020
View reviewed changes
@quangngd quangngd requested a review from jreback March 30, 2020 08:33
jreback
jreback requested changes Mar 30, 2020
View reviewed changes
@quangngd quangngd requested a review from jreback April 7, 2020 05:56
@simonjayhawkins
Copy link
Member

simonjayhawkins commented May 8, 2020

@quangngd can you merge master.

jreback
jreback reviewed May 26, 2020
View reviewed changes
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

@quangngd can you update as @TomAugspurger suggests (will need to change the test as well)

@quangngd
Copy link
Contributor Author

quangngd commented Jun 18, 2020

How tests should handle warnings?

@alimcmaster1
Copy link
Member

alimcmaster1 commented Jun 30, 2020

How tests should handle warnings?

Sure! There is a note on the contributing guide here: https://pandas.pydata.org/docs/dev/development/contributing.html#testing-warnings

Can you merge master + get a green CI?

@quangngd
Copy link
Contributor Author

quangngd commented Jul 1, 2020 •
edited
Loading

@alimcmaster1 i don't know what to do with the codecov/patch fail

simonjayhawkins
simonjayhawkins requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quangngd for working on this. can you update the parameters section of the docstring.

simonjayhawkins
simonjayhawkins reviewed Jul 2, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quangngd generally lgtm. @jreback

simonjayhawkins
simonjayhawkins requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quangngd still need to update the docstring #33091 (review)

simonjayhawkins
simonjayhawkins approved these changes Jul 8, 2020
View reviewed changes
@quangngd @simonjayhawkins
Update pandas/core/series.py
2085ed5 
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
jreback
jreback requested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, pls merge master and ping on green.

@jreback
Copy link
Contributor

jreback commented Jul 14, 2020

can you merge master and address comments

@jreback jreback merged commit 08b9c1b into pandas-dev:master Jul 15, 2020
@jreback
Copy link
Contributor

jreback commented Jul 15, 2020

thanks @quangngd

@quangngd quangngd deleted the to_markdown-index branch July 15, 2020 12:52
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jul 16, 2020
@quangngd @fangchenli
ENH: Add index option to_markdown() (pandas-dev#33091)
5e49f21
@mroeschke mroeschke mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees

No one assigned

Labels

Enhancement IO Data IO issues that don't fit into a more specific label

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

Add index=False option to_markdown()

5 participants

@quangngd @simonjayhawkins @jreback @alimcmaster1 @TomAugspurger