Skip to content

REF: do slicing before calling Block.to_native_types #33248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Apr 3, 2020
Merged

REF: do slicing before calling Block.to_native_types #33248

jreback merged 1 commit into from
Apr 3, 2020
+15 −32

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 2, 2020

Related upcoming steps:

  • Dispatch DatetimeBlock.to_native_types to DatetimeArray._format_native_types (identical behavior
  • Dispatch TimeDeltaBlock.to_native_types to TimedeltaArray._format_native_types (behavior changing, but there is a FIXME in the Block version)
  • Dispatch FloatBlock.to_native_types to Float64Index._format_native_types
  • Possibly rename to_native_types to something more informative? (i think there's an issue about deprecating/renaming the Index method)
  • in io.csvs use df._data.apply instead of iterating over blocks. Still touches internals, but its a lighter touch.

@jbrockmendel jbrockmendel mentioned this pull request Apr 3, 2020
Merged
@jreback jreback added Internals Related to non-user accessible pandas implementation Output-Formatting __repr__ of pandas objects, to_string labels Apr 3, 2020
@jreback jreback added this to the 1.1 milestone Apr 3, 2020
@jreback jreback merged commit 23d8051 into pandas-dev:master Apr 3, 2020
@jbrockmendel jbrockmendel deleted the no-data-to_native_types-2 branch April 3, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Internals Related to non-user accessible pandas implementation Output-Formatting __repr__ of pandas objects, to_string

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback