BUG: fix boolean array skipna=False for .any() and .all()

[linxiaow]

• closes BUG: BooleanArray.any with all False values and skipna=False is buggy #33253
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

I added "not self._mask.any()" to check if there is no missing value for both .any() and .all() when skipna is False. It looks fine for the example you provided.

[WillAyd]

Thanks for the PR - does this close a particular issue? Can you add tests?

[linxiaow]

@WillAyd I think yes, and I intend to close the issue here #33253. It is my first time in open source so I am not familiar with PR.

I am not familiar with testing, but I can have a try. Any suggestions before I get started

[jorisvandenbossche]

Don't worry about Travis that is failing (that's a general issue, there is already another PR trying to fix that)

[jorisvandenbossche]

The any/all tests are here:

pandas/pandas/tests/arrays/boolean/test_reduction.py

Lines 15 to 39 in 164064d

	@pytest.mark.parametrize(
	"values, exp_any, exp_all, exp_any_noskip, exp_all_noskip",
	[
	([True, pd.NA], True, True, True, pd.NA),
	([False, pd.NA], False, False, pd.NA, False),
	([pd.NA], False, True, pd.NA, pd.NA),
	([], False, True, False, True),
	],
	)
	def test_any_all(values, exp_any, exp_all, exp_any_noskip, exp_all_noskip):
	# the methods return numpy scalars
	exp_any = pd.NA if exp_any is pd.NA else np.bool_(exp_any)
	exp_all = pd.NA if exp_all is pd.NA else np.bool_(exp_all)
	exp_any_noskip = pd.NA if exp_any_noskip is pd.NA else np.bool_(exp_any_noskip)
	exp_all_noskip = pd.NA if exp_all_noskip is pd.NA else np.bool_(exp_all_noskip)
	for con in [pd.array, pd.Series]:
	a = con(values, dtype="boolean")
	assert a.any() is exp_any
	assert a.all() is exp_all
	assert a.any(skipna=False) is exp_any_noskip
	assert a.all(skipna=False) is exp_all_noskip
	assert np.any(a.any()) is exp_any
	assert np.all(a.all()) is exp_all

so you can add to that test some new cases for the all-True and all-False cases from the issue.

[jreback]

pls add a whatsnew note in bug fixes Missing section for 1.1

can you also add a test case in panda/tests/reductions/test_reductions.py

def test_all_any_params(self) is the relevant test

[jorisvandenbossche]

@linxiaow thanks for the updates. I suggested some rewording on the added whatsnew/comment

[jorisvandenbossche]

Thanks @linxiaow !