Skip to content

Conversation

@ShaharNaveh
Copy link
Contributor


Not sure where to put the note in the "whatsnew"

@datapythonista datapythonista added the Dependencies Required and optional dependencies label Apr 7, 2020
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @MomIsBestFriend

Can you have a look at the CI and see what's wrong please?

@TomAugspurger
Copy link
Contributor

In 1.0, we had dependency bumps under the "Backwards incompatible" section. https://pandas.pydata.org/docs/whatsnew/v1.0.0.html#increased-minimum-versions-for-dependencies. We can do that again, or make a new top-level section.

@simonjayhawkins
Copy link
Member

In 1.0, we had dependency bumps under the "Backwards incompatible" section.

so, by definition, this is an breaking change? is this necessary or can it keep till 2.0?

@ShaharNaveh
Copy link
Contributor Author

In 1.0, we had dependency bumps under the "Backwards incompatible" section.

so, by definition, this is an breaking change? is this necessary or can it keep till 2.0?

Haven't thought of that.


I'll push more commits when someone from the pandas-core team will tell me if this PR is relevant :)

@TomAugspurger
Copy link
Contributor

I wouldn't consider this an API breaking change. That's just the header it went under in older versions.

@ShaharNaveh
Copy link
Contributor Author

Can you have a look at the CI and see what's wrong please?

@datapythonista I have found out that there is a bug in 2.7.0 that was fixed in 2.7.3 when parsing a NaN (ref dateutil/dateutil#662)

@ShaharNaveh ShaharNaveh changed the title DEP: Bump min version of dateutil to 2.7.0 DEP: Bump min version of dateutil to 2.7.3 Apr 10, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback added this to the 1.1 milestone Apr 10, 2020
@jreback jreback merged commit 0c69615 into pandas-dev:master Apr 10, 2020
@jreback
Copy link
Contributor

jreback commented Apr 10, 2020

thanks @MomIsBestFriend

as a followon can you see if we can change code for anything that needed < 2.7.3 (i don't know if there is anything, but its possible).

@ShaharNaveh ShaharNaveh deleted the DEP-BumpMinDateUtilVersion branch April 10, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Required and optional dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants