REF: make Resolution an enum #34462
Merged
REF: make Resolution an enum #34462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 29, 2020
Contributor
|
lgtm if you can run some basic perf would be great |
Member
Author
mentioned in the OP, asv didnt show measurable change |
mroeschke
approved these changes
May 29, 2020
jreback
requested changes
May 31, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
small comment, ping on green.
jreback
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this much clearer than just using an int. No measured performance impact.