Skip to content

TST: Added test to check that the freqstr attribute of the index is p… #34572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 2 commits into from Jun 4, 2020
Merged

TST: Added test to check that the freqstr attribute of the index is p… #34572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95eaa3b
TST: Added test to check that the freqstr attribute of the index is p…
Jun 4, 2020
4bda4e6
TST: Reworked test_shift_preserve_freqstr after code review
Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pandas/tests/series/methods/test_shift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,3 +276,19 @@ def test_shift_dt64values_int_fill_deprecated(self):

expected = pd.Series([pd.Timestamp(0), ser[0]])
tm.assert_series_equal(result, expected)

@pytest.mark.parametrize("periods", [1, 2, 3, 4])
def test_shift_preserve_freqstr(self, periods):
# GH#21275
ser = pd.Series(
range(periods),
index=pd.date_range("2016-1-1 00:00:00", periods=periods, freq="H"),
)

result = ser.shift(1, "2H")

expected = pd.Series(
range(periods),
index=pd.date_range("2016-1-1 02:00:00", periods=periods, freq="H"),
)
tm.assert_series_equal(result, expected)
Copy link
Contributor

@dsaxton dsaxton Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think assert_series_equal should be enough here since it'll check the index frequencies and dtypes