TST: groupby apply with indexing and column aggregation returns the column #7002 #34647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @VirosaLi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-09 06:10:16 UTC |
dsaxton
reviewed
Jun 8, 2020
jreback
added
Groupby
Testing
simonjayhawkins
approved these changes
Jun 10, 2020
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @VirosaLi generally lgtm. a couple of unrelated changes crept in. can you revert those.
Member
|
@VirosaLi can you address @simonjayhawkins comments? Lgtm otherwise |
Member
|
@VirosaLi Thanks for the updates. lgtm. ping on green |
Member
Author
|
One of the checks is on pending for hours. Is this normal? |
Contributor
Travis is glitchy sometimes, it's green if you click through |
Contributor
|
thanks @VirosaLi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for #7002
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff