Skip to content

DOC: explain EWM #34910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 9 commits into from
Jun 20, 2020
Merged

DOC: explain EWM #34910

jreback merged 9 commits into from
Jun 20, 2020

Conversation

@KrishnaSai2020
Copy link
Contributor

@KrishnaSai2020 KrishnaSai2020 commented Jun 20, 2020

@pep8speaks
Copy link

pep8speaks commented Jun 20, 2020 •
edited
Loading

Hello @KrishnaSai2020! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-20 20:06:07 UTC

@KrishnaSai2020
Copy link
Contributor Author

KrishnaSai2020 commented Jun 20, 2020

@charlesdong1991 believe this is done please have a look when you can.

@KrishnaSai2020 KrishnaSai2020 mentioned this pull request Jun 20, 2020
Closed
5 tasks
charlesdong1991
charlesdong1991 reviewed Jun 20, 2020
View reviewed changes
Copy link
Contributor

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks much cleaner now! only one nitpick

@jreback jreback mentioned this pull request Jun 20, 2020
Closed
@jreback jreback added Clean Window rolling, ewma, expanding labels Jun 20, 2020
@jreback jreback added this to the 1.1 milestone Jun 20, 2020
KrishnaSai2020 and others added 4 commits June 20, 2020 18:42
charlesdong1991
charlesdong1991 reviewed Jun 20, 2020
View reviewed changes
Copy link
Contributor

@charlesdong1991 charlesdong1991 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, it's very close.

I think you could search pandas.core.window.ewm in pandas, and there are some other usages of it, probably in some rst files, otherwise doc validation won't pass.

An easier walkaround would be keeping the file name unchanged as ewm.py, the main purpose of this PR i think is to make EMW class name more intuitive, while not too big deal to have ewm.py in dev, but you might still need to change a few places to make CI pass.

@jreback jreback merged commit 8eb1048 into pandas-dev:master Jun 20, 2020
@jreback
Copy link
Contributor

jreback commented Jun 20, 2020

thanks @KrishnaSai2020

@KrishnaSai2020
Copy link
Contributor Author

KrishnaSai2020 commented Jun 21, 2020

@jreback np and @charlesdong1991 thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@charlesdong1991 charlesdong1991 charlesdong1991 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Clean Window rolling, ewma, expanding

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

DOC: pandas/pandas/core/window/ewm.py

4 participants

@KrishnaSai2020 @pep8speaks @jreback @charlesdong1991