TYP: remove # type: ignore for unpacking compression_args #35344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
WillAyd
approved these changes
Jul 21, 2020
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
lgtm; these are just kwargs that get passed to zip file .write correct?
Member
Author
you mean .open? |
Member
Author
|
from https://docs.python.org/3/library/gzip.html?highlight=gzipfile#module-gzip
so maybe (in a followon) remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg. compresslevel for GzipFile is an int and compression in get_handle is Optional[Union[str, Mapping[str, Any]]] = None
once we adopt TypedDict, then maybe we could be more explicit here, but for now Any is appropriate.
the ignored message for GZipFile is
error: Argument 2 to "GzipFile" has incompatible type **Dict[str, str]"; expected "int"