TYP: misc typing fixes for pandas\core\frame.py #35990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/frame.py
Outdated
| if name is not None: | ||
| itertuple = collections.namedtuple(name, fields, rename=True) | ||
| # https://github.com/python/mypy/issues/848 | ||
| # error: namedtuple() expects a string literal as the first argument [misc] |
Member
Author
There was a problem hiding this comment.
hmm, I've got the wrong mypy issue here.
cant do a cast or assert?
no, it has to be a string literal and doesn't look like mypy will change.
see python/mypy#9046 (comment)
we can remove this ignore with Final in Python 3.8 (and a later version of mypy)
Member
|
thanks @simonjayhawkins |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 31, 2020
* TYP: misc typing fixes for pandas\core\frame.py * correct issue number
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* TYP: misc typing fixes for pandas\core\frame.py * correct issue number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas\core\frame.py:1091: error: namedtuple() expects a string literal as the first argument [misc]
pandas\core\frame.py:4594: error: Need type annotation for 'names' (hint: "names: List[] = ...") [var-annotated]