CLN: rename private functions used across modules #36049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
approved these changes
Sep 1, 2020
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @jbrockmendel lgtm pending green
pandas/tests/plotting/common.py
Outdated
Comment on lines
16
to
19
|
|
||
| """ | ||
| This is a common base class used for various plotting tests | ||
| """ |
Member
There was a problem hiding this comment.
does this docstring belong inside the following class
jreback
requested changes
Sep 1, 2020
pandas/tests/plotting/test_misc.py
Outdated
| assert title_list == title[:3] + [""] | ||
|
|
||
| def test_get_standard_colors_random_seed(self): | ||
| def testget_standard_colors_random_seed(self): |
pandas/tests/plotting/test_misc.py
Outdated
|
|
||
| def test_get_standard_colors_default_num_colors(self): | ||
| from pandas.plotting._matplotlib.style import _get_standard_colors | ||
| def testget_standard_colors_default_num_colors(self): |
pandas/tests/plotting/test_misc.py
Outdated
| assert all(color == colors[0] for color in colors) | ||
|
|
||
| def test_get_standard_colors_no_appending(self): | ||
| def testget_standard_colors_no_appending(self): |
jreback
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.