Skip to content

TYP: misc fixes for numpy types 2 #36099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbrockmendel merged 1 commit into from
Sep 4, 2020
Merged

TYP: misc fixes for numpy types 2 #36099

jbrockmendel merged 1 commit into from
Sep 4, 2020

Conversation

@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Sep 3, 2020 

pandas\core\dtypes\cast.py:681: error: Incompatible types in assignment (expression has type "DatetimeTZDtype", variable has type "dtype")  [assignment]
pandas\core\dtypes\cast.py:715: error: Incompatible types in assignment (expression has type "IntervalDtype", variable has type "dtype")  [assignment]
pandas\core\dtypes\common.py:1392: error: Item "dtype" of "Union[dtype, ExtensionDtype]" has no attribute "_is_boolean"  [union-attr]
pandas\core\dtypes\common.py:111: error: Function "numpy.array" is not valid as a type  [valid-type]
pandas\core\reshape\merge.py:1873: error: Function "numpy.array" is not valid as a type  [valid-type]

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Sep 3, 2020
@jbrockmendel jbrockmendel merged commit b8e4a09 into pandas-dev:master Sep 4, 2020
@jbrockmendel
Copy link
Member

jbrockmendel commented Sep 4, 2020

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Sep 4, 2020
@simonjayhawkins simonjayhawkins deleted the np-types-2 branch September 4, 2020 17:05
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@simonjayhawkins
TYP: misc fixes for numpy types 2 (pandas-dev#36099)
ca0c124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@simonjayhawkins @jbrockmendel