Skip to content

CLN Upgrade pandas/core syntax #36453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Sep 18, 2020
Merged

CLN Upgrade pandas/core syntax #36453

jreback merged 2 commits into from
Sep 18, 2020

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Sep 18, 2020

xref #36450

@MarcoGorelli MarcoGorelli mentioned this pull request Sep 18, 2020
Closed
54 tasks
@MarcoGorelli MarcoGorelli mentioned this pull request Sep 18, 2020
Closed
dsaxton
dsaxton approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@dsaxton dsaxton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there are things to add to CI that could catch these patterns?

Edit: I see now that you mention adding to CI in the original issue.

@jreback jreback added the Code Style Code style, linting, code_checks label Sep 18, 2020
@jreback jreback added this to the 1.2 milestone Sep 18, 2020
@jreback jreback merged commit a44a704 into pandas-dev:master Sep 18, 2020
@jreback
Copy link
Contributor

jreback commented Sep 18, 2020

thanks @MarcoGorelli these are totally fine to be bigger (don't do everything all at once), but if its like this style is fine

@MarcoGorelli MarcoGorelli deleted the pyupgrade branch September 18, 2020 20:08
@MarcoGorelli MarcoGorelli restored the pyupgrade branch September 19, 2020 07:09
@MarcoGorelli MarcoGorelli deleted the pyupgrade branch October 10, 2020 14:14
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@MarcoGorelli
CLN Upgrade pandas/core syntax (pandas-dev#36453)
4ca451e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsaxton dsaxton dsaxton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcoGorelli @jreback @dsaxton