Skip to content

Conversation

@ahgamut
Copy link
Contributor

@ahgamut ahgamut commented Sep 18, 2020

Ran pyupgrade on all files unchecked in #36450. formatter pre-commit
hook had no complaints; removed unnecessary imports from the following
to satisfy flake8 hook:

pandas/tests/io/test_sql.py
pandas/test/series/test_io.py

Ran pyupgrade on all files unchecked in pandas-dev#36450. formatter pre-commit
hook had no complaints; removed unnecessary imports from the following
to satisfy flake8 hook:

pandas/tests/io/test_sql.py
pandas/test/series/test_io.py
@ahgamut ahgamut mentioned this pull request Sep 18, 2020
54 tasks
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This changes loads of files, but most of the changes are so minor I think it's OK

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware of this tool - pretty cool.

I think the CI failure is unrelated - just restarted let's see

@WillAyd WillAyd added the Code Style Code style, linting, code_checks label Sep 18, 2020
@WillAyd WillAyd added this to the 1.2 milestone Sep 18, 2020
@jreback jreback merged commit 4caafd4 into pandas-dev:master Sep 18, 2020
@jreback
Copy link
Contributor

jreback commented Sep 18, 2020

thanks @ahgamut very nice!

@ahgamut ahgamut deleted the style-py37 branch September 19, 2020 16:48
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLN upgrade to Python3.7+ syntax

4 participants