CLN: clean up new detected trailing whitespace #36588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dsaxton
approved these changes
Sep 24, 2020
Member
|
Would it work to add the |
plammens
force-pushed
the
fix-trailing-ws
branch
from
47ad3b4 to
4fc65fa
Compare
Member
|
Might need some of the same exclusions as for the end-of-file-fixer (maybe just svg and html?) |
plammens
force-pushed
the
fix-trailing-ws
branch
from
4fc65fa to
4dd1d49
Compare
Contributor
Author
Yeah just noticed that after pushing, was going to fix but something else came up. Should be all done now 🙂 |
Member
|
Thanks @plammens ! |
MarcoGorelli
added
Code Style
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
* CLN: clean up new detected trailing whitespace * BLD: add `trailing-whitespace` pre-commit hook * Update .pre-commit-config.yaml Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* CLN: clean up new detected trailing whitespace * BLD: add `trailing-whitespace` pre-commit hook * Update .pre-commit-config.yaml Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFixed the remaining trailing whitespace problems that weren't being found by
ci/code_checks.shbecause of the file type filters.