Skip to content

CLN: share setitem/getitem validators #36619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Sep 26, 2020
Merged

CLN: share setitem/getitem validators #36619

jreback merged 1 commit into from
Sep 26, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 25, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

WillAyd
WillAyd approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Clean label Sep 25, 2020
@WillAyd WillAyd added this to the 1.2 milestone Sep 25, 2020
@jreback jreback merged commit 35d5654 into pandas-dev:master Sep 26, 2020
@jbrockmendel jbrockmendel deleted the ref-share-setitem-validators branch September 26, 2020 01:21
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
CLN: share setitem/getitem validators (pandas-dev#36619)
4055419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @WillAyd @jreback