Skip to content

REGR: fillna not filling NaNs after pivot without explicitly listing pivot values #36667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonjayhawkins wants to merge 7 commits into from
Closed

REGR: fillna not filling NaNs after pivot without explicitly listing pivot values #36667

simonjayhawkins wants to merge 7 commits into from

Conversation

@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Sep 26, 2020

alternative to #34407 that only restores self._consolidate_inplace() to fix reported regression in #36495

This WILL fail see #34407 (comment) and #34407 (comment)

if all green apart from those two failures can then maybe revert #35839 and #35854

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Sep 26, 2020

cc @jbrockmendel @jorisvandenbossche

@simonjayhawkins simonjayhawkins added Internals Related to non-user accessible pandas implementation Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version labels Sep 26, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1.3 milestone Sep 26, 2020
@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Sep 26, 2020

yep, just the two tests failing with this.

@simonjayhawkins simonjayhawkins deleted the fillna-after-pivot branch September 26, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Internals Related to non-user accessible pandas implementation Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version

Projects

None yet

Milestone

1.1.3

Development

Successfully merging this pull request may close these issues.

REGR: fillna not filling NaNs after pivot without explicitly listing pivot values

2 participants

@simonjayhawkins @jorisvandenbossche