Issue36124 display of int enums #36820
Conversation
…onvert IntEnums to ints. This is controlled with a new argument called 'convert_intenum' which defaults to False.
…ts IntEnums as integers.
… to be explkcitly cast to int64 rather than int, which is 32-bit in some environments.
|
I am getting 1 failure in CI testing with an assertion unrelated to my commit. Seems similar the issue discovered here: Should I follow the same backport instructions? |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@dzimmanck can you merge master to see if there are still CI failures |
|
Sure, I will give this a try later today.
…On Sat, Nov 7, 2020, 9:42 PM Andrew Wieteska ***@***.***> wrote:
@dzimmanck <https://github.com/dzimmanck> can you merge master to see if
there are still CI failures
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36820 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3JLZT77VFFX6LKQIZVZADSOYVTVANCNFSM4SCIEWAA>
.
|
…num() test by replacing 'pd.Index' with 'Index'.
|
OK, everything looking good now. |
arw2019
left a comment
arw2019
left a comment
There was a problem hiding this comment.
Thanks @dzimmanck for following up! lgtm
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
sorry @dzimmanck got lost in the shuffle. if you can address comments.
| seen.object_ = True | ||
| break | ||
| elif util.is_integer_object(val): | ||
| if getattr(val, 'name', None) is not None and not convert_intenum: |
There was a problem hiding this comment.
i am not sure why you need this extra argument at all? the getattr (or a hasattr check) would prob be ok
There was a problem hiding this comment.
in fact it could be in the elif itself
There was a problem hiding this comment.
Thanks @jreback, I will take a look at this when I get a chance later this week.
jreback
added
Output-Formatting
|
@dzimmanck if you can respond to the comments |
|
Got side tracked. Will dial this in tomorrow.
…On Wed, Feb 10, 2021, 4:37 PM Jeff Reback ***@***.***> wrote:
@dzimmanck <https://github.com/dzimmanck> if you can respond to the
comments
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36820 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3JLZU3FXPV3VWD6VXLHNTS6MRFNANCNFSM4SCIEWAA>
.
|
|
Thanks for the PR but it appears this PR has gotten stale. Let us know if you can merge master and address the comments and we'd be happy to reopen. Closing |
|
Hi! I am having the same bug. Is there any chance this will be picked up again? |
7 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff