Skip to content

CLN: remove unnecessary DatetimeTZBlock.fillna #37040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Oct 11, 2020
Merged

CLN: remove unnecessary DatetimeTZBlock.fillna #37040

jreback merged 1 commit into from
Oct 11, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 10, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

and no need to have TimeDeltaBlock inherit from IntBlock

@jreback jreback added Clean Internals Related to non-user accessible pandas implementation Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Oct 10, 2020
@jreback jreback added this to the 1.2 milestone Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

very nice

@jreback jreback merged commit 58f7468 into pandas-dev:master Oct 11, 2020
@jbrockmendel jbrockmendel deleted the ref-notintblock branch October 11, 2020 17:36
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@jbrockmendel @JulianWgs
CLN: remove unnecessary DatetimeTZBlock.fillna (pandas-dev#37040)
ea090f7
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
CLN: remove unnecessary DatetimeTZBlock.fillna (pandas-dev#37040)
17d229a
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 31, 2020
Closed
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Jan 15, 2021
@simonjayhawkins
Revert "CLN: remove unnecessary DatetimeTZBlock.fillna (pandas-dev#37040
fe01f27 
)"

This reverts commit 58f7468.
@simonjayhawkins simonjayhawkins mentioned this pull request Jan 15, 2021
Merged
4 tasks
jreback pushed a commit that referenced this pull request Jan 16, 2021
@simonjayhawkins
REGR: fillna on datetime64[ns, UTC] column hits RecursionError (#39194)
fe92f93 
* Revert "CLN: remove unnecessary DatetimeTZBlock.fillna (#37040)"

This reverts commit 58f7468.

* add test and release note
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@simonjayhawkins @luckyvs1
REGR: fillna on datetime64[ns, UTC] column hits RecursionError (panda…
2d27bff 
…s-dev#39194)

* Revert "CLN: remove unnecessary DatetimeTZBlock.fillna (pandas-dev#37040)"

This reverts commit 58f7468.

* add test and release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Clean Internals Related to non-user accessible pandas implementation Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback