CI move check incorrect sphinx directives to pre-commit #37136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the check (which uses
grepwith the return codes inverted) doesn't catch.. warning:, while using
pygrepfrompre-commit(which is a Python implementation ofgrepwith inverted return codes) does. I think this is because grep doesn't count the newline as a characterAdvantages of moving this (and, later, other)
invgrepchecks to pre-commit are:pre-commitcomes withpygrepbuilt-in, so there's no need to manually define something likeinvgrep