Skip to content

Conversation

@dsaxton
Copy link
Contributor

@dsaxton dsaxton commented Oct 17, 2020

@dsaxton dsaxton added Bug Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Oct 17, 2020
@dsaxton dsaxton added this to the 1.2 milestone Oct 17, 2020
@dsaxton
Copy link
Contributor Author

dsaxton commented Oct 17, 2020

@jbrockmendel Seems this has been talked about before in #31710. This fix worked for me locally, but is this less trivial than it seems?

@jbrockmendel
Copy link
Member

This fix worked for me locally, but is this less trivial than it seems?

i dont think so, no

@jreback jreback modified the milestones: 1.2, 1.1.4 Oct 17, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green.

@dsaxton dsaxton merged commit 636941b into pandas-dev:master Oct 17, 2020
@dsaxton dsaxton deleted the make-values-constant branch October 17, 2020 17:04
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 17, 2020
simonjayhawkins pushed a commit that referenced this pull request Oct 17, 2020
Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
@dmitra79
Copy link

@simonjayhawkins @dsaxton
Sorry for the stupid question but how could I get the version with this fix (with conda if possible)?

@simonjayhawkins
Copy link
Member

1.1.4 is currently scheduled for release on October 30, 2020, see https://github.com/pandas-dev/pandas/milestone/78

wheels are uploaded to PyPI moreless immediately and then shortly after for conda-forge and defaults.

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: ValueError: buffer source array is read-only

5 participants