BUG: Fix inconsistent ordering between left and right in merge #37406
Conversation
| tm.assert_frame_equal(expected, result) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("how", ["left", "right"]) |
There was a problem hiding this comment.
sort=True is ok? (do we test this)? can you locate this test function near similar tests.
There was a problem hiding this comment.
Sort True was the previous default behavior. Added tests to show behavior. Moved the tests up a bit right below a nosort test
|
can you merge master and will look |
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
merged master |
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
could do this for 1.2 if you can update and merge master
� Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
Merged master too |
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
small comment ping on green
doc/source/whatsnew/v1.2.0.rst
Outdated
| - Fixed regression in :func:`merge` on merging DatetimeIndex with empty DataFrame (:issue:`36895`) | ||
| - Bug in :meth:`DataFrame.apply` not setting index of return value when ``func`` return type is ``dict`` (:issue:`37544`) | ||
| - Bug in :func:`concat` resulting in a ``ValueError`` when at least one of both inputs had a non-unique index (:issue:`36263`) | ||
| - Bug in :meth:`df.merge() <pandas.DataFrame.merge>` returning inconsistent ordering in result for ``how=right`` and ``how=left`` (:issue:`35382`) |
There was a problem hiding this comment.
you don't need to add the <...> instead do this like `:meth:`DataFrame.merge`
There was a problem hiding this comment.
also add :meth:`pandas.merge`
|
thanks @phofl very nice! |
|
Thx No they are not related. but #22449 can be closed probably, after we improved the Error Reporting here this should definitely fail as said by @TomAugspurger |
2 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffPassed sort through for right join too. Did not see a reason why not.
On a related note: I think outer joins return a inconsistent order too.
instead of
like
leftandrightnow. Would have to add asortkeyword to outer join. Should I open an issue for that?