fix windows issue pre-commit #37419
Merged
fix windows issue pre-commit #37419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Code Style
simonjayhawkins
approved these changes
Oct 26, 2020
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @MarcoGorelli
for other reviewers see #37023 (comment)
but this works for me also. (using pre-commit run -a)
Contributor
|
sure ok. pls merge on green. are the windows builds still not very stable? any ideas on this. |
Member
Author
Sure - merging then (following explicit approval - I wouldn't usually do this) |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not explicitly using
pythonin the entry, we would geton Windows
xref #37023 (comment)