Skip to content

BUG: slice_canonize incorrectly raising #37524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbrockmendel merged 4 commits into from
Oct 31, 2020
Merged

BUG: slice_canonize incorrectly raising #37524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b364642
BUG: slice_canonize incorrectly raising
jbrockmendel Oct 30, 2020
0ef3718
GH ref
jbrockmendel Oct 30, 2020
7d160cd
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 31, 2020
32c99b9
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/_libs/internals.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ cdef slice slice_canonize(slice s):
Convert slice to canonical bounded form.
"""
cdef:
Py_ssize_t start = 0, stop = 0, step = 1, length
Py_ssize_t start = 0, stop = 0, step = 1

if s.step is None:
step = 1
Expand Down Expand Up @@ -239,7 +239,7 @@ cdef slice slice_canonize(slice s):
if stop > start:
stop = start

if start < 0 or (stop < 0 and s.stop is not None):
if start < 0 or (stop < 0 and s.stop is not None and step > 0):
raise ValueError("unbounded slice")

if stop < 0:
Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/internals/test_internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,13 @@ def test_zero_step_raises(self, slc):
with pytest.raises(ValueError, match=msg):
BlockPlacement(slc)

def test_slice_canonize_negative_stop(self):
# GH#37524 negative stop is OK with negative step and positive start
slc = slice(3, -1, -2)

bp = BlockPlacement(slc)
assert bp.indexer == slice(3, None, -2)

@pytest.mark.parametrize(
"slc",
[
Expand Down