Skip to content

TYP: fix mypy ignored error in pandas/tests/io/test_fsspec.py #37797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 1 commit into from
Nov 13, 2020
Merged

TYP: fix mypy ignored error in pandas/tests/io/test_fsspec.py #37797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions pandas/tests/io/test_fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@
"dt": date_range("2018-06-18", periods=2),
}
)
# the ignore on the following line accounts for to_csv returning Optional(str)
# in general, but always str in the case we give no filename
# error: Item "None" of "Optional[str]" has no attribute "encode"
text = df1.to_csv(index=False).encode() # type: ignore[union-attr]
text = str(df1.to_csv(index=False)).encode()


@pytest.fixture
Expand Down