Skip to content

Conversation

@suvayu
Copy link
Contributor

@suvayu suvayu commented Nov 14, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Add a section in the user guide to illustrate the use of np.where and np.select to enlarge a dataframe conditionally. The example is taken from SO, as mentioned in this issue.

Copy link
Contributor

@ivanovmg ivanovmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Nice and clear.
Couple of comments below.
Pending green.

@jreback jreback added this to the 1.2 milestone Nov 14, 2020
@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Nov 14, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks @jd

Setting with enlargement conditionally using :func:`numpy`
----------------------------------------------------------

An alternative to :meth:`~pandas.DataFrame.where` is to use :func:`numpy.where`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference compared to using DataFrame.where ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joris, with np.where, enlarging the dataframe by adding a column is straightforward. Also, it naturally extends to multiple conditions with np.select.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suvayu thanks for the answer! Looking at the example now, I think the main difference is that with np.where, your x/y values to take from don't need to be a Series to start with (eg Series.where always takes the values from the calling Series where the condition is True, and so indeed you wouldn't be able to achieve the actual example here)

@jreback jreback merged commit 0364787 into pandas-dev:master Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

thanks @suvayu

@suvayu suvayu deleted the user-guide-indexing branch November 18, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants