Skip to content

TST: add messages to bare pytest raises in pandas/tests/io/pytables/test_timezones.py #37975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 4 commits into from
Nov 20, 2020
Merged

TST: add messages to bare pytest raises in pandas/tests/io/pytables/test_timezones.py #37975

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e26fff
add messages to assert
Nov 19, 2020
a73d058
Merge remote-tracking branch 'upstream/master' into assert-msg-with-p…
Nov 20, 2020
3f0da33
generalise message to pass test
Nov 20, 2020
ed87d30
make regex consistent within file
Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions pandas/tests/io/pytables/test_timezones.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,13 @@ def test_append_with_timezones_dateutil(setup_path):
),
index=range(5),
)
with pytest.raises(ValueError):

msg = (
r"invalid info for \[values_block_1\] for \[tz\], "
r"existing_value \[dateutil/.*US/Eastern\] "
r"conflicts with new value \[dateutil/.*EET\]"
)
with pytest.raises(ValueError, match=msg):
store.append("df_tz", df)

# this is ok
Expand All @@ -100,7 +106,13 @@ def test_append_with_timezones_dateutil(setup_path):
),
index=range(5),
)
with pytest.raises(ValueError):

msg = (
r"invalid info for \[B\] for \[tz\], "
r"existing_value \[dateutil/.*EET\] "
r"conflicts with new value \[dateutil/.*CET\]"
)
with pytest.raises(ValueError, match=msg):
store.append("df_tz", df)

# as index
Expand Down Expand Up @@ -169,7 +181,12 @@ def test_append_with_timezones_pytz(setup_path):
),
index=range(5),
)
with pytest.raises(ValueError):

msg = (
r"invalid info for \[values_block_1\] for \[tz\], "
r"existing_value \[US/Eastern\] conflicts with new value \[EET\]"
)
with pytest.raises(ValueError, match=msg):
store.append("df_tz", df)

# this is ok
Expand All @@ -187,7 +204,12 @@ def test_append_with_timezones_pytz(setup_path):
),
index=range(5),
)
with pytest.raises(ValueError):

msg = (
r"invalid info for \[B\] for \[tz\], "
r"existing_value \[EET\] conflicts with new value \[CET\]"
)
with pytest.raises(ValueError, match=msg):
store.append("df_tz", df)

# as index
Expand Down