Skip to content

REF: move __from_arrow__ to common base class for numeric masked arrays #38411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 3 commits into from
Dec 12, 2020
Merged

REF: move __from_arrow__ to common base class for numeric masked arrays #38411

jreback merged 3 commits into from
Dec 12, 2020

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 11, 2020

xref #38110

@jorisvandenbossche jorisvandenbossche added NA - MaskedArrays Related to pd.NA and nullable extension arrays Refactor Internal refactoring of code labels Dec 11, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Dec 11, 2020
@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 11, 2020
Open
10 tasks
jbrockmendel
jbrockmendel reviewed Dec 11, 2020
View reviewed changes
pandas/core/arrays/numeric.py
results.append(num_arr)

if len(results) == 1:
# avoid additional copy in _concat_same_type
Copy link
Member

@jbrockmendel jbrockmendel Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is the only change, otherwise this is pretty much copy/paste?

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed (that's the second commit, the first one is mainly copy/paste)

jbrockmendel
jbrockmendel approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit 643d62c into pandas-dev:master Dec 12, 2020
@jreback
Copy link
Contributor

jreback commented Dec 12, 2020

thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the EA-masked-consolidate-arrow branch December 13, 2020 07:30
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jorisvandenbossche @luckyvs1
REF: move __from_arrow__ to common base class for numeric masked arra…
25e41a6 
…ys (pandas-dev#38411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees

No one assigned

Labels

NA - MaskedArrays Related to pd.NA and nullable extension arrays Refactor Internal refactoring of code

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jorisvandenbossche @jreback @jbrockmendel