Skip to content

Conversation

@afeld
Copy link
Contributor

@afeld afeld commented Dec 31, 2020

  • Added missing . to the .. includes
  • Put the includes in a folder to exclude from Sphinx, to avoid :orphan: being written to the HTML

Before:

Screen_Shot_2020-12-30_at_7_08_52_PM

After:

Screen Shot 2020-12-30 at 7 07 41 PM


  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

small linting error but the doc build passed: https://github.com/pandas-dev/pandas/pull/38839/checks?check_run_id=1628340684

@jreback jreback added the Docs label Dec 31, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- Added missing `.` to the `.. include`s
- Put the includes in a folder to exclude from Sphinx, to avoid
  `:orphan:` being written to the HTML
@jreback jreback added this to the 1.3 milestone Dec 31, 2020
@jreback jreback merged commit 784de76 into pandas-dev:master Dec 31, 2020
@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

thanks @afeld (pls check dev docs for rendered results in a while)

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants