TST: Series.update with categorical #38873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ftrihardjo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-03 02:14:22 UTC |
Member
|
Hi @ftrihardjo - could you please put a meaningful title and link to the issue you're closing in the pull request body? |
jreback
added
Categorical
jreback
changed the title
jreback
requested changes
Jan 1, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
looks good, ping on green,
| def test_update_extension_array_series(self, result, target, expected): | ||
| result.update(target) | ||
| tm.assert_series_equal(result, expected) | ||
| def test_update_with_categorical_type(self): |
Contributor
There was a problem hiding this comment.
can you add a blank line before the test.
| tm.assert_series_equal(result, expected) | ||
| def test_update_with_categorical_type(self): | ||
| # GH 25744 | ||
| t = CategoricalDtype(['a', 'b', 'c', 'd']) |
Contributor
|
see here: https://github.com/pandas-dev/pandas/pull/38873/checks?check_run_id=1634842619 make sure you have |
jreback
approved these changes
Jan 3, 2021
Contributor
|
thanks @ftrihardjo |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff