Skip to content

ASV: Add xlrd engine for xls file #39137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 2 commits into from
Jan 13, 2021
Merged

ASV: Add xlrd engine for xls file #39137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f50d82b
ASV: Add xlrd engine for xls file
phofl Jan 12, 2021
09c1097
Remove wrong code
phofl Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions asv_bench/benchmarks/io/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ def time_write_excel(self, engine):

class ReadExcel:

params = ["openpyxl", "odf"]
params = ["xlrd", "openpyxl", "odf"]
param_names = ["engine"]
fname_excel = "spreadsheet.xlsx"
fname_excel_xls = "spreadsheet.xls"
fname_odf = "spreadsheet.ods"

def _create_odf(self):
Expand All @@ -63,10 +64,16 @@ def setup_cache(self):
self.df = _generate_dataframe()

self.df.to_excel(self.fname_excel, sheet_name="Sheet1")
self.df.to_excel(self.fname_excel_xls, sheet_name="Sheet1")
self._create_odf()

def time_read_excel(self, engine):
fname = self.fname_odf if engine == "odf" else self.fname_excel
if engine == "xlrd":
fname = self.fname_excel_xls
elif engine == "odf":
fname = self.fname_odf
else:
fname = self.fname_excel
read_excel(fname, engine=engine)


Expand Down